feat: set callback to post for tnm and added new connector #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elijah0kello
commented
Nov 21, 2024
•
elijah0kello
commented
- set callback method to post for tnm core connector
- added mtn zambia core connector
feat: change callback req method to post for tnm
elijah0kello
requested review from
bushjames and
elnyry-sam-k
as code owners
|
@elnyry-sam-k , kindly help me review this PR |
| @@ -162,7 +162,7 @@ paths: | |||
| description: Bad request | |||
|
|
|||
| /callback: | |||
| put: | |||
| post: | |||
There was a problem hiding this comment.
hi @elijah0kello , why change to post?
Typically Mojaloop's callbacks all use PUT method, is there a justification to make this change?
There was a problem hiding this comment.
That callback is for the DFSP to send us a transfer notification. The DFSP sends it in POST and not PUT like we earlier had built
|
thanks for the PR @elijah0kello , sure |
|
That callback is for the DFSP to send us a transfer notification. The DFSP sends it in POST and not PUT like we earlier had built |
chore: added logging for every new request body and errors
…erence-connectors into ft/mtn-zm-core-connector
feat: mtn core connector for zambia
|
Added commits for the mtn zambia core connector |
elijah0kello
changed the title
elijah0kello
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.