Deprecate modUserProfile->sessionid and do not set value #16697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16697 +/- ##
=========================================
Coverage 21.53% 21.53%
+ Complexity 10734 10733 -1
=========================================
Files 565 565
Lines 32540 32539 -1
=========================================
Hits 7007 7007
+ Misses 25533 25532 -1 ☔ View full report in Codecov by Sentry. |
Mark-H
approved these changes
Jan 29, 2025
smg6511
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Marks the modUserProfile->sessionid field as deprecated and does not set the value when a user session is initiated or session id changes.
Why is it needed?
Security enhancement.
How to test
Make sure data is not added to the field for new users or updated for existing users when sessions are utilized.
Related issue(s)/PR(s)
n/a