Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new function ChangeField into the manager to change a column without … #13400

Closed
wants to merge 1 commit into from

Conversation

flolopdel
Copy link

…drop the existing content, you must update the schema xml changing the field before call this function

What does it do?

Change a existing column without drop the existing content, you must update the schema xml changing the field before call this function

Why is it needed?

To change a column field without drop the old values

Related issue(s)/PR(s)

…drop the existing content, you must update the schema xml changing the field befor call this function
@Mark-H
Copy link
Collaborator

Mark-H commented Mar 28, 2017

Hi @flolopdel!

Thanks, this looks really interesting and I've wondered why we didn't have a method like that before...

Unfortunately though this is the wrong place to send that pull request... all changes to xPDO need to go into the main xPDO repo at https://github.com/modxcms/xpdo (probably the 2.x branch - the 3.x branch is newer but wont be incorporated until MODX 3).

The xPDO repo gets pulled into MODX at a later point.

Maybe worth changing the method name to renameField? There's already an alterField which can be used to change the position of the field on the table, so rename might be a bit more descriptive in what this does to avoid confusion.

@Jako
Copy link
Collaborator

Jako commented Apr 9, 2017

The PR was opened on xPDO now. So I close it here.

@Jako Jako closed this Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants