-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update package.json to support latest LTS version of Node.js #3376
base: main
Are you sure you want to change the base?
chore: update package.json to support latest LTS version of Node.js #3376
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -6,7 +6,7 @@ Thank you for your interest in contributing to Module Federation! Before startin | |||
|
|||
1. [Fork](https://help.github.com/articles/fork-a-repo/) the Module Federation repository into your own GitHub account. | |||
2. [Clone](https://help.github.com/articles/cloning-a-repository/) the repository to your local machine. | |||
3. Checkout a new branch from `main` or `canary`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no canary
branch
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many changes here, probably pnpm 9 lockfile is not compatible with v8
@2heal1 You can take care of this |
@@ -2,8 +2,8 @@ | |||
"name": "module-federation", | |||
"version": "0.0.0", | |||
"engines": { | |||
"node": "^18", | |||
"pnpm": "^8.11.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use corepack, should us exact pnpm version otherwise this can cause issues
Description
Updated development requirements and contributing guidelines:
Addresses #3375
Although it is possible to use nvm/fnm, there is no convenient way to use both pnpm 8 and pnpm 9
Related Issue
N/A - Maintenance update
Types of changes
Checklist