-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook-addon): use new api to get the storybook virtual static modules #3298
Open
fyodorovandrei
wants to merge
15
commits into
module-federation:main
Choose a base branch
from
fyodorovandrei:upgrade-package-deps-to-allow-to-use-new-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(storybook-addon): use new api to get the storybook virtual static modules #3298
fyodorovandrei
wants to merge
15
commits into
module-federation:main
from
fyodorovandrei:upgrade-package-deps-to-allow-to-use-new-api
+266
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1129b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
…om `@module-federation/sdk`
… upgrade-package-deps-to-allow-to-use-new-api # Conflicts: # packages/storybook-addon/package.json
…allow-to-use-new-api # Conflicts: # packages/storybook-addon/package.json
ScriptedAlchemy
approved these changes
Dec 12, 2024
…allow-to-use-new-api
…allow-to-use-new-api # Conflicts: # packages/storybook-addon/package.json
Lock file outdated |
… upgrade-package-deps-to-allow-to-use-new-api # Conflicts: # packages/storybook-addon/package.json
…-use-new-api' into upgrade-package-deps-to-allow-to-use-new-api # Conflicts: # packages/storybook-addon/package.json
@ScriptedAlchemy done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
normalizeStories
is imported from@storybook/core
and not more from deprecated@storybook/core-common
Related Issue
Types of changes
Checklist