Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[driver] DW3110 UWB radio #1210

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[driver] DW3110 UWB radio #1210

merged 2 commits into from
Nov 5, 2024

Conversation

Javask
Copy link
Contributor

@Javask Javask commented Oct 1, 2024

Reopening this under my name on request by @rleh.

Driver and example are working and have been tested on real hardware.
Most of the important features should be implemented.

@rleh rleh self-requested a review October 1, 2024 22:12
@rleh rleh mentioned this pull request Oct 1, 2024
Closed
4 tasks
@rleh rleh added this to the 2024q4 milestone Oct 13, 2024
salkinium
salkinium approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cc @rleh I assume you already reviewed this in the RCA, so I can just merge it?

@chris-durand chris-durand self-requested a review November 3, 2024 17:24
@chris-durand
Copy link
Member

@salkinium I'm taking a look at this tomorrow evening. Wanted to review it since some time but never got to it. Can we wait one more day?

chris-durand
chris-durand reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

examples/nucleo_f401re/dw3110-communication/main.cpp Outdated Show resolved Hide resolved
src/modm/driver/radio/dw3110/dw3110_definitions.hpp Outdated Show resolved Hide resolved
src/modm/driver/radio/dw3110/dw3110_phy.hpp Show resolved Hide resolved
src/modm/driver/radio/dw3110/dw3110_phy_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/radio/dw3110/dw3110_phy.hpp Show resolved Hide resolved
src/modm/driver/radio/dw3110/dw3110_phy_impl.hpp Show resolved Hide resolved
Javask and others added 2 commits November 5, 2024 13:23
@Javask @rleh @kingelilol
[driver] radio: Add DW3110 UWB phy
6bf8875 
Co-authored-by: Raphael Lehmann <[email protected]>
Co-authored-by: Elias H. <[email protected]>
@Javask @rleh @kingelilol
[examples] nucleo_f401re: Add communication example using dw3110 driver
e579250 
Co-authored-by: Raphael Lehmann <[email protected]>
Co-authored-by: Elias H. <[email protected]>
@Javask
Copy link
Contributor Author

Javask commented Nov 5, 2024

Fixed the register definition, removed the const specifier, removed the checkResult member function and replaced with std::ranges::equal and added __NOP() to the while loop.
Also made a small change in the example to change the tx buffer length, requested by @rleh since the buffer might contain uninitialized values that get transmitted.
I don't have hardware on hand until this evening, so the changes have not yet been run on hardware. I will retest the example this evening just to make sure.

@Javask
Copy link
Contributor Author

Javask commented Nov 5, 2024

Still works.

chris-durand
chris-durand approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium merged commit e579250 into modm-io:develop Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh Awaiting requested review from rleh

Assignees
No one assigned
Labels
advanced 🤯 example 🔑 feature 🚧
Milestone
2024q4
Development

Successfully merging this pull request may close these issues.
4 participants
@Javask @chris-durand @salkinium @rleh