chore: use PAT token for pull request in e2e test #275
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <[email protected]>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
bergwolf
reviewed
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the authentication logic for the
modctllogin step in the end-to-end workflow. Now, the workflow uses a Personal Access Token (PAT) for authentication on pull request events, and falls back to the defaultGITHUB_TOKENfor other events.Authentication logic improvements:
.github/workflows/e2e.yml: Added conditional logic to use theCR_PATsecret formodctllogin during pull request events, and theGITHUB_TOKENfor all other events. This ensures appropriate credentials are used depending on the workflow trigger.