Add missing exception documentation for public APIs#1339
Merged
stephentoub merged 4 commits intomainfrom Feb 21, 2026
Merged
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Contributor
|
@copilot is this really the only missing exception comment? Please search for others. |
…TaskAsync, and NotifyTaskStatusAsync Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Contributor
Author
Found 4 more missing
All other public methods in both files already had the documentation. |
Copilot
AI
changed the title
[WIP] Add missing exception documentation for public APIs
Add missing exception documentation for public APIs
Feb 21, 2026
stephentoub
approved these changes
Feb 21, 2026
halter73
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
<exception cref="McpException">XML documentation to public methods that callSendRequestAsyncorSendNotificationAsyncbut were not documenting the exception. All other public methods in both files already correctly document this exception — these were all task-related methods that were likely added together and missed the pattern.Methods fixed in
McpClient.Methods.csGetTaskResultAsyncGetTaskAsyncListTasksAsync(both the convenience and rawListTasksRequestParamsoverloads)CancelTaskAsyncMethods fixed in
McpServer.Methods.csNotifyTaskStatusAsync💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.