InteropGen Refactor #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1f214e7.
xezno
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Some cool stuff here! Never knew about FrozenDictionary before - I assume it's faster than ImmutableDictionary and ReadOnlyDictionary.
We should probably remove the paths that we have hard-coded as fallbacks for missing environment variables - we should probably throw an error if these aren't available, especially in the case of Vulkan where the path depends on the version number - but I believe I was the one that wrote that code originally so I'll fix that after merging.
Some really cool work overall though. This has reduced the InteropGen execution time from ~7 seconds to around half that, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a majority of the code in the InteropGen project. Functionally there is no difference. Performance-wise it takes roughly less than half as long to do the generation. In my few tests, it goes from about 12-15 seconds to 6-7. Almost all of the time is spent in Clang now.