WIP: enable integer overflow checks for release builds #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integer overflow checks would be nice to have, however, these cause summary and ring operations to fail with what is either a mishandled panic or a stack related regression, resulting in an extremely cursed series of observations:
(if an integer overflow panic was the cause i would expect to see the same fault in speculos?)
(something has gone wrong at the OS level when attempting to respond, for example, attempting to panic while exceeding the stack pointer limitation?)
(a panic should result in an abort, but this could be a failure of the nanos_sdk panic handler?)
reproduce by:
duck diamond ...
) to match the test vectorsmake nanosplus-load
cargo run --bin ledger-mob-tests -- --target hid tx --input tests/vectors/tx3.json