Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PKITS tests to integration tests #75

Closed

Conversation

nick-mobilecoin
Copy link
Collaborator

Motivation

@github-actions
Copy link

github-actions bot commented May 2, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags

@nick-mobilecoin nick-mobilecoin force-pushed the nick/pkits-integration-folder branch 2 times, most recently from f4b7128 to f9f8601 Compare May 2, 2023 22:12
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (nick/pkits-4.1@5cd3159). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 38ec517 differs from pull request most recent head ce93532. Consider uploading reports for the commit ce93532 to get more accurate results

@@                Coverage Diff                @@
##             nick/pkits-4.1      #75   +/-   ##
=================================================
  Coverage                  ?   97.85%           
=================================================
  Files                     ?        8           
  Lines                     ?     2008           
  Branches                  ?        0           
=================================================
  Hits                      ?     1965           
  Misses                    ?       43           
  Partials                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested review from a team, jcape and awygle and removed request for jcape and a team May 3, 2023 14:08
@nick-mobilecoin nick-mobilecoin force-pushed the nick/pkits-integration-folder branch from f9f8601 to 38ec517 Compare May 3, 2023 14:20
@nick-mobilecoin
Copy link
Collaborator Author

punting on implementing x509 chain parsing logic.

@nick-mobilecoin nick-mobilecoin deleted the nick/pkits-integration-folder branch October 3, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants