Add logic to decode and verify certificate #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
github-actions
bot
added
rust
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
332e519 to
c673d94
Compare
github-actions
bot
added
the
github_actions
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 95.78% 96.23% +0.44%
==========================================
Files 3 4 +1
Lines 902 1062 +160
==========================================
+ Hits 864 1022 +158
- Misses 38 40 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
commented
Mar 22, 2023
nick-mobilecoin
commented
Mar 22, 2023
nick-mobilecoin
commented
Mar 22, 2023
11 tasks
nick-mobilecoin
requested review from
a team and
NotGyro
and removed request for
a team
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
03ad95a to
2049d62
Compare
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
2049d62 to
323d501
Compare
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
323d501 to
66470b8
Compare
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
66470b8 to
3c7e090
Compare
❌ Unreviewed dependencies found
|
samdealy
approved these changes
Apr 19, 2023
awygle
approved these changes
Apr 19, 2023
A DER encoded certificate can now be decoded and have it's signature verified
Previously the x509 certificate logic was always built as part of the `mc-attestation-verifier` crate. Now the x509 certificate logic is guarded by the `alloc` feature so that the crate can still be built in no alloc environments with limited capability.
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
4e56a0d to
4a73918
Compare
Previously the PEM strings used in testing were embedded in the test modules. Now the pem contents are in individual files which are accessed via `include_str!`.
nick-mobilecoin
force-pushed
the
nick/cert-verify
branch
from
4a73918 to
aa567c9
Compare
samdealy
approved these changes
Apr 25, 2023
|
@nick-mobilecoin queued this pull request to merge with Graphite. |
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DER encoded certificate can now be decoded and have it's signature
verified
Added expiry time as a task on #50