Fix undeclared function rb_mmtk_enabled_p when compiling
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that in CI and locally the `mmtk` branch wasn't compiling and
failing on the following compilation errors:
```
gc.c:10074:9: error: call to undeclared function 'rb_mmtk_enabled_p'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (rb_mmtk_enabled_p()) {
^
```
```
error.c:1076:39: error: call to undeclared function 'rb_mmtk_enabled_p'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (rb_current_execution_context(!rb_mmtk_enabled_p())) {
^
```
The `internal/mmtk_support.h` header is included fine, but these two
lines were using `ifdef USE_MMTK` rather than `if USE_MMTK`. Changing
these allows CRuby mmtk branch to compile correctly.
|
Actually we need this change too, then it compiles #64 |
|
That must be a typo. We used to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in CI and locally the
mmtkbranch wasn't compiling and failing on the following compilation errors:The
internal/mmtk_support.hheader is included fine, but these two lines were usingifdef USE_MMTKrather thanif USE_MMTK. Changing these allows CRuby mmtk branch to get past these compilation errors.See https://github.com/mmtk/ruby/actions/runs/8416953029/job/23044511739 for an example of these errors.