Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download classpath from gnu ftp port 21 #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 15, 2024

No description provided.

Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to change the URL, I suggest we use HTTPS instead. FTP has been considered deprecated for a long time due to bad performance, insecurity, lack of Unicode support, etc.

@@ -68,7 +68,7 @@
<property name="classpath.web-archive" value="classpath-0.${classpath.version}.tar.gz"/>
<mkdir dir="${classpath.package.dir}"/>
<cachedGet key="${classpath.web-archive}"
src="ftp://ftp.gnu.org/gnu/classpath/${classpath.web-archive}"
src="ftp://ftp.gnu.org:21/gnu/classpath/${classpath.web-archive}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src="ftp://ftp.gnu.org:21/gnu/classpath/${classpath.web-archive}"
src="https://ftp.gnu.org/gnu/classpath/${classpath.web-archive}"

@qinsoon
Copy link
Member Author

qinsoon commented Jan 16, 2024

I don't plan to merge this. The problem seems to have disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants