-
Notifications
You must be signed in to change notification settings - Fork 220
Allow outputting RSS, Atom, and JSON feeds #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6958a90 to
21507eb
Compare
|
This is pretty neat! How would you expect the server to handle pagination? Say Feed data is in a db, and the http request is for page 2. First query the data for that page, then populate the Feed struct, then pass that to the Renderer. Does that sound right? |
|
Thank you for the contribution! I'll look through the changes this week hopefully. One thing to consider is if we want to have these changes target the |
🤦🏻 I was totally unaware of the |
|
Thank you @cdzombak for the PR. I'm using it very successfully for a home project I have. My $0.02 is that it's worth landing into the v1 branch even if it would need work for v2, as it's useful as is and v2 isn't stable yet. Really appreciate the project as a whole! Thank you all and hope you all have a happy new year! |
This PR allows gofeed to convert the universal
Feedrepresentation back into RSS, Atom, or JSON feed structures (performing the inverse oftranslators) and render those structures out to RSS, Atom, or JSON feeds.