v2: Implement ParseOptions foundation for parser API #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the foundation for ParseOptions as specified in #244. It establishes the basic structure and API changes needed for v2, with some features left for future implementation.
What's Implemented
Core ParseOptions Structure
ParseOptionsstruct with all fields from the RFCRequestOptionssub-struct for HTTP configurationStrictnessOptionsfor parsing behavior controlAPI Updates
*ParseOptionsparameter (can be nil)ParseURLto context-first:ParseURL(ctx, url, opts)ParseURLWithContext- context is now always requiredBasic Features
Feed.OriginalFeedLeft for Future PRs
Breaking Changes
All Parse methods now require
*ParseOptions:ParseURL is now context-first:
Testing
All existing tests have been updated and are passing. The API is ready for use, though some ParseOptions fields are not yet implemented.
Closes #244