Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Options to Rotating Circle #120

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mljoshi
Copy link

@mljoshi mljoshi commented Feb 25, 2024

Added light blue, lilac, pink, and dark blue color options for the rotating circle in settings.
Added preview for the currently selected color option in settings.
Changes made based on issue #118. Dark blue contrasts much more with the light theme's background than the default color.
Dark blue:
image
Original:
image
New settings screen:
image

mljoshi and others added 6 commits February 24, 2024 12:25
Added light blue, lilac, pink, and dark blue color options for the rotating circle in settings
Added preview for the currently selected color option in settings

Co-Authored-By: Alvaro De La Cruz <[email protected]>
Co-Authored-By: alszzy <[email protected]>
Add Custom Rotating Circle Color
@mljoshi mljoshi marked this pull request as ready for review February 25, 2024 23:58
Copy link
Owner

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thanks so much for the contribution :)
I added a few comments, I think we'll want to adjust a few things first. Can you take a look at the suggestion?
Also, I'm very very very busy lately, so, sorry, it might take me a while to respond (as you probably already noticed). Can you also provide screenshots/recordings of this in both light and dark mode in android and ios?
I know it's a lot, but given that I don't have time to test it out I need as much context as possible in order to help with this 😓

src/stores/settings.ts Outdated Show resolved Hide resolved
src/screens/exercise-screen/breathing-animation.tsx Outdated Show resolved Hide resolved
src/screens/settings-screen/settings-screen.tsx Outdated Show resolved Hide resolved
@mljoshi
Copy link
Author

mljoshi commented Mar 16, 2024

Apologies for the delay; here are the screenshots on iOS and Android in both light and dark mode: https://drive.google.com/drive/folders/14BHiisWfBLZlYfe-dFPv7vWu-5YuyCas?usp=drive_link
(sort by name, double click the first image, and use arrow keys to traverse through more easily)

@mljoshi mljoshi requested a review from mmazzarolo March 17, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants