Conversation
…ation supports; and (c) models member protection optimization.
|
I will review soon. Thanks for the contribution |
| #if !NET_TOO_OLD_VER | ||
| public IReadOnlyList<string> Chunk(ReadOnlySpan<char> text) | ||
| { | ||
| // MemoryExtensions.Split(text, lineSeparators, StringSplitOptions.None); |
There was a problem hiding this comment.
What is this commented out code for?
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.13.12" /> | ||
| <PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.12" /> | ||
| <PackageReference Include="BenchmarkDotNet" /> |
There was a problem hiding this comment.
@kingcean Can you run benchmarks before before and after the changes and add the results to the PR description? I want to see if we have a measurable impact with this change. We may need to make this benchmark more interesting though
There was a problem hiding this comment.
It would be also good to use this to analyze what else we can improve.
| <AssemblyVersion>1.5.0.0</AssemblyVersion> | ||
| <FileVersion>1.5.0.0</FileVersion> | ||
| <AssemblyVersion>1.6.0.0</AssemblyVersion> | ||
| <FileVersion>1.6.0.0</FileVersion> |
There was a problem hiding this comment.
Should we move all versions to 2.0?
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(TargetFramework)' == 'netstandard1.0' OR '$(TargetFramework)' == 'net45' OR '$(TargetFramework)' == 'net40' OR '$(TargetFramework)' == 'net35'"> | ||
| <DefineConstants>NET_TOO_OLD_VER</DefineConstants> |
There was a problem hiding this comment.
Can you update the github actions test run to ensure we test both an older and a newer version? Not sure how hard this is, but would be nice to ensure things functions properly with and without the ifdef being true.
|
@kingcean are you still interested in moving this forward? |
Sorry for the late reply, I will find time to follow up later. |
2 participants
This PR is a significant change of core library
DiffPlex.ReadOnlySpan<char>supports to differ and its accessories. At the same time, update the TFM to enable this feature on the available targets. This type is always used for some high performance scenarios to decrease unnecessary memory costs.System.Text.Jsonfor older TFM platforms, e.g. on .NET Frameworks. And please note this feature is disabled on .NET Strandard 1.0 because of not supported.