Skip to content

Add blockforest learners #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Add blockforest learners #474

wants to merge 45 commits into from

Conversation

bblodfon
Copy link
Collaborator

Solves #228 by adding the regr and classif blockforest learners

Abubaker Hassan and others added 29 commits October 17, 2024 23:51
Add custom method to aorsf learner
b5be605
@sebffischer
Merge branch 'main' into aorsf_control_custom
3339991
@sebffischer
Merge branch 'main' into aorsf_control_custom
097f713
@bblodfon
Merge branch 'main' into aorsf_control_custom
ddae4a2
@bblodfon
remove 'omit' as it causes test observations to be less than what is …
60b9f17 
…expected
@bblodfon
remove omit, add missings property
90c984a
@bblodfon
na_action can be also used during prediction
ac3f1e2
@bblodfon
logical is not supported
b136042
@bblodfon
fix note
ed22805
@bblodfon
fix surv.aorsf test
7d6bcf5
@bblodfon
fix param test
da3bed5
@bblodfon
remove 'omit' na_action, add missings property
2623dda
@bblodfon
optimize and fix tests for aorsf regr and classif learners
a7f219b
@bblodfon
run document()
559138f
@bblodfon
update doc for fastai
61dc56e
@bblodfon
fix styling issues
ad3987a
@bblodfon
update news
9b987ff
@sebffischer
Update NEWS.md
2083c97
@sebffischer
Update NEWS.md
e3292ea
@bblodfon
better doc
6a125ab
@bblodfon
Merge branch 'main' into add_blockforest_learners
04ab1c7
@bblodfon
small refactoring
342a184
@bblodfon
add draft regr and classif blockforest learners
62dc378
@bblodfon
refactor: model output is just the forest slot
4b18892
@bblodfon
add marshaling for regr.blockforest (test fails otherwise)
332a55f
@bblodfon
sava marshaled model in rds tmp file
fa0eab1
@bblodfon
add docs for learners
bf82aad
@bblodfon
add parameter tests for blockforest learners
4970269
@bblodfon
add autotests
deb1bf0
@bblodfon
Copy link
Collaborator Author

@sebffischer I found in regr.blockforest that an encapsulation test wasn't working (for classif and surv though it works strangely?), so I implemented marshaling, but still it fails (though I manually see that marshalling works) - I don't know how to further debug this, let's discuss tomorrow?

@sebffischer
Copy link
Member

What's the error for the regression encapsulation test?

@bblodfon bblodfon requested a review from sebffischer August 27, 2025 15:26
sebffischer
sebffischer reviewed Sep 5, 2025
View reviewed changes
@bblodfon
Copy link
Collaborator Author

bblodfon commented Sep 5, 2025

Waiting for RcppCore/RcppArmadillo#479 to be fixed and vew version on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebffischer sebffischer sebffischer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bblodfon @sebffischer