Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLCubes CI #942

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

MLCubes CI #942

wants to merge 5 commits into from

Conversation

hasan7n
Copy link
Contributor

@hasan7n hasan7n commented Sep 18, 2024

Fixes #ISSUE_NUMBER

Proposed Changes

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@hasan7n hasan7n requested a review from a team as a code owner September 18, 2024 12:02
@hasan7n hasan7n marked this pull request as draft September 18, 2024 12:03
Copy link
Contributor

github-actions bot commented Sep 18, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.52%. Comparing base (c6d178f) to head (ac2c98b).

Files with missing lines Patch % Lines
GANDLF/cli/generate_metrics.py 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   93.61%   93.52%   -0.10%     
==========================================
  Files         168      168              
  Lines        9898     9912      +14     
==========================================
+ Hits         9266     9270       +4     
- Misses        632      642      +10     
Flag Coverage Δ
unittests 93.52% <35.71%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants