Create decodeURI and encodeURI #179
Open
+268
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobslisboa
force-pushed
the
feat/decode_uri
branch
5 times, most recently
from
1563035
to
225eff3
Compare
pedrobslisboa
changed the title
pedrobslisboa
force-pushed
the
feat/decode_uri
branch
3 times, most recently
from
c19c4f3
to
6bdef39
Compare
pedrobslisboa
force-pushed
the
feat/decode_uri
branch
2 times, most recently
from
543d85c
to
a3cc2bb
Compare
pedrobslisboa
force-pushed
the
feat/decode_uri
branch
from
a3cc2bb
to
e58db1a
Compare
pedrobslisboa
force-pushed
the
feat/decode_uri
branch
from
9d48bb2
to
e58db1a
Compare
* main: Add useSyncExternalStore hooks (#177)
pedrobslisboa
force-pushed
the
feat/decode_uri
branch
from
be6573d
to
fcc7b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #174
Description
This PR attempts to add decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent. It was strongly inspired by quick and aligning with JS tests: #174 (comment)
Process
The first attempt was basic copying the C code of quickjs as ocaml, but there were some issues that I wasn't able to identify what was wrong. That's why, besides its strong inspiration from Quickjs, the code differs from it in some approaches.
My eyes are also used to this code, so you may find some improvements that I don't, and please comment here about them.