Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React.cloneElement] Raise in any other case than lowercase element #164

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[React.cloneElement] Raise in any other case than lowercase element #164

merged 3 commits into from
Aug 28, 2024

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Aug 14, 2024 •
edited
Loading

Before it silently didn't clone, this can lead to unexpected bugs

@davesnx davesnx merged commit fb68360 into main Aug 28, 2024
2 checks passed
@davesnx davesnx deleted the clone-raise-for-wrong-args branch August 28, 2024 09:31
davesnx added a commit that referenced this pull request Aug 28, 2024
@davesnx
Merge branch 'main' of github.com:ml-in-barcelona/server-reason-react…
334e4eb 
… into render-rsc-payload

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  [`React.cloneElement`] Raise in any other case than lowercase element (#164)
  Make Js.Math.min/max
  Add native code to Js.String.split (#168)
  Async components ppx support (#157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davesnx