-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[WIP] Tensor scale nvfp4 #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nastya236
wants to merge
11
commits into
ml-explore:main
Choose a base branch
from
nastya236:tensor-scale-nvfp4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Tensor scale nvfp4 #3022
+506
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tensor-scale-nvfp4
awni
reviewed
Jan 20, 2026
| * w_q (array): The quantized version of ``w`` | ||
| * scales (array): The quantization scales | ||
| * tensor_scale (array): The per-tensor float32 absolute max |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of a nit, but I don't really love the name tensor_scale. Partly because we call them array in MLX. What do you think about global_scale, or maybe array_scale?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tensor fp32 scale for
nvfp4quantization.Python API changes:
quantizereturnstensor_scaleifmode==nvfp4dequantizeinputstensor_scaleifmode==nvfp4qqmminputs 4 arrays if weights provided quantized andmode==nvfp4: quantized weights, scales and tensor_scaleChanges to the quantization:
Quantize::eval_gpuquantize : 2 kernels launched: 1)all_reducewithAbsMaxreduction 2) use computedabsmaxin thefp_quantizekernelQuantize::eval_gpudequantize: inputsabsmaxand uses it infp_dequantize.Changes to
qqmm:tensor_amax_xandtensor_amax_wto computealphafor BLAS operation. Also allocatebeta = 0because cublaslt requires both pointers to be on device or host.It still looks ugly.