Skip to content

Conversation

@saltomodules
Copy link

@saltomodules saltomodules commented Dec 30, 2016

The call to getException on line 63 currently receives a second argument in milliseconds.

However getException expects a value in seconds because the key parameter is ultimately tested against event_length which is denominated in seconds. If you pass in milliseconds, getException wil always return false and no overlaps of recurrent events and their exceptions will be filtered out.

Fixed by dividing the second argument of the getException call by 1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant