Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update inquirer to latest version #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erezrokah
Copy link

Fixes #76.

Please note this is a breaking change due to requiring a minimal Node.js version >= 12.

Breaking changes in inquirer are dropping Node.js 6 support in v7 and Node.js 10 in v8.
See https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%407.0.0 and https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%408.0.0

@@ -48,7 +51,7 @@
"dependencies": {
"debug": "^4.0.1",
"es6-promisify": "^6.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be removed later assuming Node.js >=12

@@ -48,7 +51,7 @@
"dependencies": {
"debug": "^4.0.1",
"es6-promisify": "^6.0.0",
"inquirer": "^6.0.0",
"inquirer": "^8.2.0",
"minimist": "^1.2.0",
"mkdirp": "^0.5.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also

@XhmikosR
Copy link
Contributor

I had a closer look and I don't think Node.js < 8 was supported in tabtab 3.x, but then again, the project lacks an engines version so I'm saying this from the CI only.

So, it seems like this is not a breaking change.

I also made #79 and #80 which reduces the deps and updates things :)

@XhmikosR
Copy link
Contributor

NVM my comment about Node 10, just saw your upstream PR SBoudrias/Inquirer.js#1077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerable dependency [email protected]
2 participants