Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mapping for Stanton-DJC-4: Auto DJ #13800

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update mapping for Stanton-DJC-4: Auto DJ #13800

wants to merge 2 commits into from

Conversation

xxxmicrobexxx
Copy link

Added:

AutoDJ enable/disable -> shift + TX/FX press (above VU meters)
AutoDJ fade to next track -> TX/FX press

@xxxmicrobexxx
Update Stanton-DJC-4.midi.xml
7d120e7 
AutoDJ enable/disable -> shift + TX/FX press (above VU meters)
AutoDJ fade to next track -> TX/FX press
@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@xxxmicrobexxx
Copy link
Author

xxxmicrobexxx commented Oct 26, 2024 via email

@ronso0
Copy link
Member

ronso0 commented Oct 26, 2024

shift + TX/FX press

Interesting, this rotary encoder has been unmapped. In conjunction with the Browse encoder it would allow a better library navigation, eg. map encoder turn to "move focus" which would allow to focus the searchbar (and scroll through recent queries with Brwose).
But that is of course unrelated to your change, just saying. If you like to work on that let me know.

@ronso0
Copy link
Member

ronso0 commented Oct 26, 2024

LGTM, just the indentation.

@ronso0
Copy link
Member

ronso0 commented Oct 26, 2024

Mapping updates should go to the current stable branch, currently 2.4 (unless they require new features).
Please change the base branch here, then rebase locally onto 2.4 and force-push.

Can you also take care of updating the manual?
https://manual.mixxx.org/2.4/en/hardware/controllers/stanton_djc_4
https://github.com/mixxxdj/manual/blob/2.4/source/hardware/controllers/stanton_djc_4.rst
(actually, this is requirement for new mappings)

@xxxmicrobexxx
Copy link
Author

xxxmicrobexxx commented Oct 26, 2024 via email

@ronso0
Copy link
Member

ronso0 commented Oct 26, 2024

I just noticed that [Library],MoveFocus is mapped

mixxx/res/controllers/Stanton-DJC-4.midi.xml

Lines 1763 to 1766 in 9e1efe2

<group>[Library]</group>
<key>MoveFocus</key>
<status>0x90</status>
<midino>0x27</midino>
so the searchbar can be focused and scrolled.
but it's not documented in the manual.
Is it Browse press?

I see navigation is easy, but with the current mapping it's not possible to use some new features.
[Library],GoToItem has some helpful context-dependent actions, see https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[Library]-GoToItem
My favorite is using it for jumping from Search to the tracks view, because selecting a search query and going to tracks can be done with one encoder.
Same for the sidebar, and pushing buttons in the track menu and popup dialogs.

But this can be done in another PR if you're interested.

Here, we only need to fix the indentations and rebase onto 2.4.
And update the manual with the new mapping (and 'MoveFocus' while you're at it ; )

@xxxmicrobexxx
Copy link
Author

I just noticed that [Library],MoveFocus is mapped

mixxx/res/controllers/Stanton-DJC-4.midi.xml

Lines 1763 to 1766 in 9e1efe2

<group>[Library]</group>
<key>MoveFocus</key>
<status>0x90</status>
<midino>0x27</midino>

so the searchbar can be focused and scrolled.
but it's not documented in the manual.
Is it Browse press?

Browser press jumps from track list to search to sidebar (repeated)

In the sidebar shift + Load B/D opens a branch, shift + Load A/C closes

I see navigation is easy, but with the current mapping it's not possible to use some new features. [Library],GoToItem has some helpful context-dependent actions, see https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[Library]-GoToItem My favorite is using it for jumping from Search to the tracks view, because selecting a search query and going to tracks can be done with one encoder. Same for the sidebar, and pushing buttons in the track menu and popup dialogs.

I think you are saying what I said above about jumping. I am fairly experienced with PHP but this stuff is all new to me so I am almost out of my depth :o)

But this can be done in another PR if you're interested.

PR? Yes, I aam interested. I think there is room for improving the DJC4 controller and I am happy to be part of working on it and testing it.

Here, we only need to fix the indentations and rebase onto 2.4. And update the manual with the new mapping (and 'MoveFocus' while you're at it ; )

Am I able to update the manual? I think it is here on github, I'll have a look.

@xxxmicrobexxx
Copy link
Author

Manual updated - I added to the Mixer section, which seemed like the best spot. I have no problem with it being elsewhere.

@ronso0
Copy link
Member

ronso0 commented Oct 27, 2024

There is a separate repo for the manual
https://github.com/mixxxdj/manual
so you need to open a PR there.

@ronso0
Copy link
Member

ronso0 commented Oct 27, 2024

Okay, so Fx/Tx press could be mapped to GoToItem, or is that doing something else already?

@xxxmicrobexxx
Copy link
Author

There is a separate repo for the manual https://github.com/mixxxdj/manual so you need to open a PR there.

Yep, and I have updated that.

@xxxmicrobexxx
Copy link
Author

Okay, so Fx/Tx press could be mapped to GoToItem, or is that doing something else already?

I am very happy mapping tx/fx to autodj as I have in my proposed controller update.

The thing that is hard to figure out is which DJC4 buttons/wheels etc aren't being used in Mixxx

@ronso0
Copy link
Member

ronso0 commented Oct 28, 2024

Okay, so Fx/Tx press could be mapped to GoToItem, or is that doing something else already?

I am very happy mapping tx/fx to autodj as I have in my proposed controller update.

🤦‍♂️
of course. (I shouldn'respond on mobile where it's easy to miss something)

@ronso0
Copy link
Member

ronso0 commented Oct 28, 2024

The thing that is hard to figure out is which DJC4 buttons/wheels etc aren't being used in Mixxx

Yeah. Put a sticker on each control that's described in https://manual.mixxx.org/2.4/en/hardware/controllers/stanton_djc_4
😉

@ronso0
Copy link
Member

ronso0 commented Oct 28, 2024

There is a separate repo for the manual https://github.com/mixxxdj/manual so you need to open a PR there.

Yep, and I have updated that.

Umm, I don't see a corresponding PR https://github.com/mixxxdj/manual/pulls
You need to push your local changes to your fork? With that, open a PR against mixxxdj/manual?

@xxxmicrobexxx
Copy link
Author

Ooops, I committed but don't think I created the pull request, done now.

@ronso0 ronso0 changed the title Update Stanton-DJC-4 controller Update mapping for Stanton-DJC-4: Auto DJ Oct 28, 2024
@ronso0 ronso0 mentioned this pull request Oct 28, 2024
Open
@ronso0
Copy link
Member

ronso0 commented Oct 28, 2024

Okay, thanks. It's mixxxdj/manual#698

(I renamed all Stanton DJC4 PRs so we know which is which)

ronso0
ronso0 reviewed Oct 28, 2024
View reviewed changes
res/controllers/Stanton-DJC-4.midi.xml
Comment on lines +2668 to +2677
<control>
<group>[AutoDJ]</group>
<key>fade_now</key>
<description>AutoDJ fade to next track</description>
<status>0x90</status>
<midino>0x28</midino>
<options>
<normal/>
</options>
</control>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, indentation is still wrong.
Another try

Suggested change
<control>
<group>[AutoDJ]</group>
<key>fade_now</key>
<description>AutoDJ fade to next track</description>
<status>0x90</status>
<midino>0x28</midino>
<options>
<normal/>
</options>
</control>
<control>
<group>[AutoDJ]</group>
<key>fade_now</key>
<description>AutoDJ fade to next track</description>
<status>0x90</status>
<midino>0x28</midino>
<options>
<normal/>
</options>
</control>

@ronso0
Copy link
Member

ronso0 commented Oct 28, 2024

Regarding the GoToItem changes in #13804:
Now, GoToItem is Shift+Scratch which is in the deck sections, but the AutoDJ buttons are in the Brwose section.
In order to have all related actions closer together physically, what do you think about swapping these

  • AutoDJ toggle / fade: Shift + left/right Scratch
  • GoToItem: TX press

I'm sorry for being pedantic about this, it's just that I like to polish it UX-wise now that we touch the mapping.
If you agree we could as well combine the two change sets in one PR (this one).
What do you think? Hope this isn't too much of a hazzle for you, git-wise. If it is, I can jump in and push to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 left review comments

Assignees
No one assigned
Labels
controller mappings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxxmicrobexxx @JoergAtGithub @ronso0