Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KORG KAOSS DJ Revamp #11639

Closed
wants to merge 16 commits into from
Closed

KORG KAOSS DJ Revamp #11639

wants to merge 16 commits into from

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jun 9, 2023

Continuation of #4301 which seems to be abandoned and is in a bad state.

I haven't touched the corresponding manual PR mixxxdj/manual#430 yet.

@uklotzde uklotzde changed the title [WIP] KORG KAOSS DJ Revamp KORG KAOSS DJ Revamp Jun 10, 2023
@uklotzde uklotzde marked this pull request as ready for review June 10, 2023 13:58
Swiftb0y
Swiftb0y reviewed Jun 10, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm. some of the new parts could be a little DRYer, are you interested in some suggestions or do you just want this merged?

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor Author

mostly lgtm. some of the new parts could be a little DRYer, are you interested in some suggestions or do you just want this merged?

Yes please. I have tried to simplify the code a bit without rewriting it while preserving the proposed behavior.

Swiftb0y
Swiftb0y reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything more would involve quite large refactorings unfortunately.

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved
res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved
@pi43r
Copy link
Contributor

pi43r commented Jul 4, 2023

Hey,
Thanks for taking this on you.
I started a PR for the manual. It's a bit of a mess but I can try to revise it.
Did you change any mappings?

@uklotzde
Copy link
Contributor Author

uklotzde commented Jul 4, 2023

Did you change any mappings?

I only cleaned up the code a bit and fixed/removed non-working parts as a starting point for future improvements.

raphaelquast and others added 12 commits July 4, 2023 13:27
@raphaelquast @uklotzde
add functions to fully control the file browser
f8d5fcb 
<TAP>                : open folder
<TAP> + <TAP>        : double-tap to close folder
<SHIFT LEFT> + <TAP> : tap bpm of LEFT track
<SHIFT RIGHT> + <TAP> : tap bpm of RIGHT track

<browseKnob>           : browse library up & down
<SHIFT> + <browseKnob> : toggle focus between Playlist and File-Browser

<LOAD A/B>           : load track
<SHIFT> + <LOAD A/B> : open/close folder in file-browser
@raphaelquast @uklotzde
add looping function
57b66d8
@raphaelquast @uklotzde
add functions to control QuickEffectRack super knobs
68f5e66 
<SHIFT> + <TOUCHPAD X> : control super knob of QuickEffectRack for deck 1
<SHIFT> + <TOUCHPAD Y> : control super knob of QuickEffectRack for deck 2
@raphaelquast @uklotzde
update controller-assignments .xml file
bd3492a
@uklotzde
korg-kaoss-dj: Fix Fx knob binding
431fd7e
@uklotzde
korg-kaoss-dj: Reformat code and fix eslint issues
71e6d1c
@uklotzde
korg-kaoss-dj: Rename script binding functions
9ce9e04
@uklotzde
korg-kaoss-dj: Simplify and reformat code
4bedd10
@uklotzde
korg-kaoss-dj: Fix handling of resetting the efx params on release
138b6cd
@uklotzde
korg-kaoss-dj: Simplify handling of Fx toggle buttons
0b64919
@uklotzde
korg-kaoss-dj: Fix eslint issues
5c7154e
@uklotzde
korg-kaoss-dj: Simplify JS code by switching to ES7
7b8f587
@uklotzde uklotzde changed the base branch from 2.3 to 2.4 July 4, 2023 11:28
@uklotzde
Copy link
Contributor Author

uklotzde commented Jul 4, 2023

Now targeting 2.4.

@uklotzde
Copy link
Contributor Author

uklotzde commented Jul 4, 2023

Those selective CI checks that fail in various circumstances by not covering all use cases are a real burden. A brute force enforcement once would have been much easier.

Swiftb0y
Swiftb0y reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investing some time in the cleanup. Got one more modernization opportunity for you. the rest LGTM.

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved
uklotzde
uklotzde commented Jul 7, 2023
View reviewed changes
res/controllers/Korg-KAOSS-DJ-scripts.js
// initialise decks
// Seb Dooris, Fayaaz Ahmed, Lee Arromba, Raphael Quast

// Using `const`/`let` causes ReferenceError: KAOSSDJ is not defined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swiftb0y But why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect the "controller namespace" (KAOSSDJ in this case) to be accessible via the global object. That only happens when variable is declared via var in the global context. Declaring it using const or let won't do that. You can confirm this in node js using the following snippet:

const a = "a";
let b = "b";
var c = "c";

console.log(`a: ${a}, global.a: ${global.a}\nb: ${b}, global.b: ${global.b}\nc: ${c}, global.c: ${global.c}`);

I'm not sure if we can access these variables without the global object, but we could try.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix shouldn't be particularly difficult, I expect about 10-20 extra lines. Though I don't have time to look into this right now.

Swiftb0y

This comment was marked as off-topic.

Sign in to view

@Swiftb0y Swiftb0y self-assigned this Sep 13, 2023
@uklotzde uklotzde closed this by deleting the head repository Jan 23, 2024
@pi43r
Copy link
Contributor

pi43r commented Jan 29, 2024 •
edited
Loading

Sorry to pitch in on this again.
What needs to be done so it can go into 2.4?
It would be sad to see this not getting integrated

@daschuer
Copy link
Member

Unfortunately it looks like that Uwe dies not have interest to continue working on this mapping.
Do you have interest to help?

A first step would be to issue a new pull request, test it and test it. Than we need to consider what us left for a merge to the 2.4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y left review comments

Assignees

@Swiftb0y Swiftb0y

Labels
build code quality controller mappings needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uklotzde @pi43r @daschuer @Swiftb0y @raphaelquast