feat(controllers): add new controller mapping for Numark NS6II #11075

Swiftb0y · 2022-11-17T22:37:33Z

~~Manual still TODO~~
manual PR

Swiftb0y · 2022-11-17T23:01:04Z

tests are failing because of the EffectUnits. I guess I'll have to redo them when I find the time. Works locally so far.

github-actions · 2023-02-16T00:07:18Z

This PR is marked as stale because it has been open 90 days with no activity.

github-actions · 2023-09-22T00:07:10Z

This PR is marked as stale because it has been open 90 days with no activity.

Swiftb0y · 2023-09-22T00:23:51Z

Ah yes, good old stale. I have had and used this controller for about 5 years now, one day I'll get around to polishing the mapping enough for merge.

Still, a surface-level review in the meantime would be appreciated.

github-actions · 2023-12-22T00:07:32Z

This PR is marked as stale because it has been open 90 days with no activity.

acolombier

Hard to review without the device to test. but it is looking good overall. Also I'm sure that if you've been using it this long, you probably had a chance to polish most of the small bug lying around :)

Some comment cruft here and there that might be worth removing or documenting if useful for alternate behaviours (note that if the latter, you might want to consider the controller settings).
Did you have a chance to prepare the manual for that?

Swiftb0y · 2024-06-11T16:39:49Z

I'll try to give this another look and ping you when I think its ready. Thanks for the review.

Swiftb0y · 2024-07-17T14:56:42Z

@acolombier please re-review ;)
I'm mostly satisfied with the mapping (there are a couple TODO's but I'm really not in the mood to implement those).
I'll focus on the manual page next.

JoergAtGithub · 2024-08-04T10:24:03Z

res/controllers/midi-controller-api.d.ts

@@ -1,4 +1,6 @@

+type MidiInputHandler = (channel: number, control: number, value:number, status:number, group:string) => void;
+


I can't spot the place, where this type is defined in our API. Is this a mapping specific type, that doesn't belong to the API?

Its the type our input handlers are expected to be https://github.com/mixxxdj/mixxx/wiki/midi%20scripting#midi-input-handling-functions

Swiftb0y · 2024-08-30T19:16:15Z

friendly ping... ;)

acolombier · 2024-09-02T20:00:57Z

res/controllers/Numark-NS6II-scripts.js

+    // grey could be an alternative as well as a backlight color.
+    off: NS6II.USE_BUTTON_BACKLIGHT ? NS6II.PAD_COLORS.RED.DIMMER : NS6II.PAD_COLORS.OFF,


Could it be worth adding a dynamic setting for that?

yes, I'll add that as a follow up, but I wanted to keep this branch targetted at 2.4

acolombier · 2024-09-02T20:05:37Z

res/controllers/Numark-NS6II-scripts.js

+    });
+    this.scratch = new components.Button({
+        midi: [0x90 + channelOffset, 0x07],
+        // shift: [0x90+channelOffset,0x46]


Can this be removed as this is redundant with line 409/414?

technically yes, but I would've preferred this to stay here instead of having it buried in the implementation.

acolombier · 2024-09-02T20:07:22Z

res/controllers/Numark-NS6II-scripts.js

+    this.parameterLeft = new components.Button({
+        midi: [0x90, 0x28],
+        unshift: function() {
+            // TODO change hotcue page


Is this outstanding? Or should it be removed?

nah, its technically outstanding, but I really didn't want to bother implementing that because components.HotcueButton is not setup for that.

acolombier · 2024-09-02T20:07:29Z

res/controllers/Numark-NS6II-scripts.js

+    this.parameterRight = new components.Button({
+        midi: [0x90, 0x29],
+        unshift: function() {
+            // TODO change hotcue page


acolombier · 2024-11-17T20:10:51Z

I had a thorough look at that eslint failing, I really can't find what is wrong here. I reproduced to the exact everything the pipeline does (merge commit and container) and yet, everything is fine on my local. I'm running out of idea currently, but I'll try to think of something else.
Otherwise, since eslint is giving me a green light locally, I'd say we could ignore the CI failing and merge it, wdyt?
The build is a blocker tho IMO

Swiftb0y · 2024-11-18T14:46:15Z

well the build failure is fortunately unrelated and fixed with #13904. I'll investigate whats wrong with pre-commit.

Otherwise the eslint stdout is only printed if eslint actually fails. In the case of warnings, we don't want pre-commit to fail, but we still want to bring attention to the users code that something is suboptimal. In order for that to work the output still needs to be shown even when the hook does not fail. Setting a hook to be `verbose` is the only way to make that happen as far as I can tell.

Swiftb0y · 2024-11-20T18:46:28Z

now depends on #13913

github-actions bot added the controller mappings label Nov 17, 2022

Swiftb0y force-pushed the numark-ns6ii branch 3 times, most recently from 1f3330e to 6f16bba Compare November 17, 2022 22:51

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Feb 16, 2023

Swiftb0y force-pushed the numark-ns6ii branch from 932d897 to 8845fc0 Compare June 5, 2023 21:24

github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Jun 6, 2023

Swiftb0y force-pushed the numark-ns6ii branch 2 times, most recently from 7872f2b to fccd316 Compare June 22, 2023 22:46

Swiftb0y mentioned this pull request Jul 11, 2023

Add mapping Numark NS4FX #11728

Open

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Sep 22, 2023

github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Sep 23, 2023

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Dec 22, 2023

daschuer changed the base branch from 2.3 to 2.4 June 9, 2024 15:29

acolombier reviewed Jun 11, 2024

View reviewed changes

Swiftb0y force-pushed the numark-ns6ii branch from 5930081 to 13299ca Compare June 26, 2024 19:01

Swiftb0y removed the stale Stale issues that haven't been updated for a long time. label Jul 17, 2024

Swiftb0y mentioned this pull request Aug 3, 2024

Numark NS6II docs mixxxdj/manual#687

Open

JoergAtGithub reviewed Aug 4, 2024

View reviewed changes

Swiftb0y added this to the 2.4.2 milestone Aug 16, 2024

acolombier reviewed Sep 2, 2024

View reviewed changes

daschuer marked this pull request as draft September 15, 2024 19:36

daschuer removed this from the 2.4.2 milestone Sep 15, 2024

Swiftb0y force-pushed the numark-ns6ii branch 2 times, most recently from 88b88a0 to 38762b8 Compare November 15, 2024 14:24

Swiftb0y marked this pull request as ready for review November 15, 2024 14:24

Swiftb0y added 6 commits November 20, 2024 19:36

fix: fix eslint-diff-plugin on CI.

cffd953

fix: add back eslint camelcase exception for common-hid-packet-parser

8a70f8b

fix: fix easy eslint complaints

b999ae7

refactor: remove now unused local .eslintrc.json

edd0d74

feat: remove eslintrc compat logic from eslint.config

3950f1b

Swiftb0y force-pushed the numark-ns6ii branch from 9810bbb to cf579f6 Compare November 20, 2024 18:44

Swiftb0y added 13 commits November 20, 2024 19:45

feat(controllers): add new controller mapping for Numark NS6II

8674999

add Typescript MidiInputHandler definition

59477c7

update mapping to ES6 featureset

f53ddb6

fix broken splitcue workaround

c3c4395

properly shutdown takeoverleds

a0865ff

misc cleanup

23f9ea9

refactor takeoverLeds, reduce traffic

42ffcfd

add second hotcuepage; add hotcue_focus_color buttons

21f189c

implement pad mode for controlling a track's key

a9ce2b2

add padmode for setting intro and outro markers

4591d57

fix precommit

f612967

document settings

ddab58c

fix: account for a dewcks rate_dir for displaying rate

691831b

Swiftb0y force-pushed the numark-ns6ii branch from cf579f6 to 691831b Compare November 20, 2024 18:46

github-actions bot added the code quality label Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(controllers): add new controller mapping for Numark NS6II #11075

feat(controllers): add new controller mapping for Numark NS6II #11075

Swiftb0y commented Nov 17, 2022 •

edited

Loading

Swiftb0y commented Nov 17, 2022

github-actions bot commented Feb 16, 2023

github-actions bot commented Sep 22, 2023

Swiftb0y commented Sep 22, 2023

github-actions bot commented Dec 22, 2023

acolombier left a comment

Swiftb0y commented Jun 11, 2024

Swiftb0y commented Jul 17, 2024

JoergAtGithub Aug 4, 2024

Swiftb0y Aug 5, 2024

Swiftb0y commented Aug 30, 2024

acolombier Sep 2, 2024

Swiftb0y Sep 2, 2024

acolombier Sep 2, 2024

Swiftb0y Sep 2, 2024

acolombier Sep 2, 2024

Swiftb0y Sep 2, 2024

acolombier Sep 2, 2024

acolombier commented Nov 17, 2024 •

edited

Loading

Swiftb0y commented Nov 18, 2024

Swiftb0y commented Nov 20, 2024

		@@ -1,4 +1,6 @@

		type MidiInputHandler = (channel: number, control: number, value:number, status:number, group:string) => void;

		// grey could be an alternative as well as a backlight color.
		off: NS6II.USE_BUTTON_BACKLIGHT ? NS6II.PAD_COLORS.RED.DIMMER : NS6II.PAD_COLORS.OFF,

feat(controllers): add new controller mapping for Numark NS6II #11075

Are you sure you want to change the base?

feat(controllers): add new controller mapping for Numark NS6II #11075

Conversation

Swiftb0y commented Nov 17, 2022 • edited Loading

Swiftb0y commented Nov 17, 2022

github-actions bot commented Feb 16, 2023

github-actions bot commented Sep 22, 2023

Swiftb0y commented Sep 22, 2023

github-actions bot commented Dec 22, 2023

acolombier left a comment

Choose a reason for hiding this comment

Swiftb0y commented Jun 11, 2024

Swiftb0y commented Jul 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Swiftb0y commented Aug 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acolombier commented Nov 17, 2024 • edited Loading

Swiftb0y commented Nov 18, 2024

Swiftb0y commented Nov 20, 2024

Swiftb0y commented Nov 17, 2022 •

edited

Loading

acolombier commented Nov 17, 2024 •

edited

Loading