Traktor S3: Restructured effect section

[soerenbe]

Hi there,
I just got my S3 and set it up for Mixxx. I read the documentation and the most parts where very good explained and quite understandable.

I had a really hard time reading the effect section. As described in the manual they are a little complex. It took me 2 evenings to understand all the functions and the different modes. Since I was a first time reader/user I thought this is a good time to work on it.

I found 2 major issues with this section:

1. ) The button names in the document are a little confusing. Especially the 'Filter enabled' button is labeled as 'On' on the controller. So I renamed it to 'Filter On'. I also introduced the buttons at the begin of the section.
2. ) The 3 different modes are mentioned in 3 different section: introduction, change mode, mode description. So I was constantly scrolling up and down to get my information. Also the "filter mode" was not listed as a section - just is functionality "Assigning Effects".
   I restructured the section that it should now be easier to read it from top to bottom.

Preview:
https://manual.mixxx.org/2.3/en/hardware/controllers/native_instruments_traktor_kontrol_s3.html#effects
https://deploy-preview-485--mixxx-manual.netlify.app/hardware/controllers/native_instruments_traktor_kontrol_s3.html#effects

[ronso0]

For a better overview, I think would help to mention the mode indicators here as well, instead of 'hiding' this info in each mode's section (maybe have it both places)

[soerenbe]

Sounds reasonable. I added a short description. Since I want to avoid up/down scolling, I kept the description in the section.

[ronso0]

I think we should add softTakeover to https://manual.mixxx.org/2.3/en/glossary.html
I filed #486

[soerenbe]

For now I do not reference the glossary. I think this should be done in this PR.

[ronso0]

Thank you for this improvement!
I've left some comments.

@ywwg Wanna take a look?

https://manual.mixxx.org/2.3/en/hardware/controllers/native_instruments_traktor_kontrol_s3.html#effects
https://deploy-preview-485--mixxx-manual.netlify.app/hardware/controllers/native_instruments_traktor_kontrol_s3.html#effects

[soerenbe]

I did not left a comment, but I finished already 3 weeks ago. Feel free to send me more feedback (or merge the PR). :-)

[Swiftb0y]

I'm sorry for not merging this yet. We were waiting for the original author to state their opinion. Unfortunately it doesn't seem like they have time right now. @ronso0 Do you consider your review sufficient and want to merge this now?

[ronso0]

Thank you, just a clean-up idea and one more hwlabel

[ronso0]

Suggested change

	#. Filter Mode (initial) - It is indicated when the :hwlabel:`FILTER ON` buttons have the same colors as the individual decks.
	#. Effect Chain Edit Mode - It is indicated when the :hwlabel:`FILTER ON` buttons are all the same color as one of the effect buttons.
	#. Effect Focus Mode - It is indicated when :hwlabel:`FILTER ON` buttons are all the same color as one of the effects, and one of the :hwlabel:`FX SELECT` buttons is blinking.
	#. Filter Mode (initial): :hwlabel:`FILTER ON` buttons have the same color as the respective decks.
	#. Effect Chain Edit Mode: :hwlabel:`FILTER ON` buttons are all the same color as one of the :hwlabel:`FX SELECT` buttons
	#. Effect Focus Mode: :hwlabel:`FILTER ON` buttons are all the same color as one of the effects, and one of the :hwlabel:`FX SELECT` buttons is blinking.

[ronso0]

Thanks for the reminder. Seems @ywwg is n/a, so I left a final review, then let's merge it and improve further when necessary.