Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node 22 #3157

Merged
merged 10 commits into from
Dec 28, 2024
Merged

Update to Node 22 #3157

merged 10 commits into from
Dec 28, 2024

Conversation

DMedina6
Copy link
Contributor

@DMedina6 DMedina6 commented Dec 24, 2024 •
edited by georgedias
Loading

  • Move SAF CLI to node 22.0.0
    • Workflows
      • build-macos.yml
      • build-windows-linux.yml
      • build-rpm.yml
      • e2e-ci.yml
      • linter.yml
      • push-to-npm-gpr.yml
    • .nvmrc
    • Dockerfile
    • package.json

@aaronlippold aaronlippold requested a review from Copilot December 24, 2024 16:47
Copilot
Copilot AI reviewed Dec 24, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • Dockerfile: Language not supported
  • package.json: Language not supported
  • .github/workflows/build-macos.yml: Evaluated as low risk
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

This pull request has a conflict. Could you fix it @DMedina6?

georgedias and others added 8 commits December 27, 2024 15:58
@georgedias
Merge branch 'main' into node-update
ba09e89
@georgedias
move necessary file to node v22
a0ec70e 
Signed-off-by: George M Dias <[email protected]>
@georgedias
increased timeout for delta test
c5381e3 
Signed-off-by: George M Dias <[email protected]>
@georgedias
testing deltata tests
ea77b61 
Signed-off-by: George M Dias <[email protected]>
@georgedias
testing delta test-2
c0f22e0 
Signed-off-by: George M Dias <[email protected]>
@georgedias
testing delta test-3
c961271 
Signed-off-by: George M Dias <[email protected]>
@georgedias
testing delta test-3
9479df9 
Signed-off-by: George M Dias <[email protected]>
@georgedias
testing delta test-4
b1f2668 
Signed-off-by: George M Dias <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgedias georgedias added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Dec 28, 2024
@georgedias georgedias merged commit 04b71e1 into main Dec 28, 2024
18 checks passed
@mergify mergify bot deleted the node-update branch December 28, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@georgedias georgedias georgedias approved these changes

Assignees
No one assigned
Labels
ready-to-merge Used by mergify to identify if a PR is ready to merge into main.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMedina6 @georgedias