Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Cookie Domain Propogation Added #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed: Cookie Domain Propogation Added #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/mitre/dsmiley/httpproxy/ProxyServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
*
* @author David Smiley [email protected]
*/
@SuppressWarnings({"deprecation", "serial", "WeakerAccess"})
@SuppressWarnings({"deprecation", "WeakerAccess"})
public class ProxyServlet extends HttpServlet {

/* INIT PARAMETER NAME CONSTANTS */
Expand Down Expand Up @@ -465,7 +465,7 @@ protected void closeQuietly(Closeable closeable) {
}

/** These are the "hop-by-hop" headers that should not be copied.
* http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html
* <a href="http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html">RFC2616</a>
* I use an HttpClient HeaderGroup class instead of Set&lt;String&gt; because this
* approach does case insensitive lookup faster.
*/
Expand Down Expand Up @@ -602,7 +602,7 @@ protected Cookie createProxyCookie(HttpServletRequest servletRequest, HttpCookie
);
servletCookie.setComment(cookie.getComment());
servletCookie.setMaxAge((int) cookie.getMaxAge());
// don't set cookie domain
servletCookie.setDomain(cookie.getDomain());
servletCookie.setSecure(servletRequest.isSecure() && cookie.getSecure());
servletCookie.setVersion(cookie.getVersion());
servletCookie.setHttpOnly(cookie.isHttpOnly());
Expand Down
Loading