Adds Survey to Rate Challenges After Correct Flag Submission #224 #532
Conversation
sesheikholeslam
changed the title
Removing JavaScript dependency manually from within Github, as the desktop client doesn't want to commit directly to this PR.
Removing JavaScript dependency manually from within Github, as the desktop client doesn't want to commit directly to this PR.
Removing JavaScript dependency manually from within Github, as the desktop client doesn't want to commit directly to this PR.
| click_on "Update Survey" | ||
|
|
||
| assert_text "Survey was successfully updated" | ||
| click_on "Back" |
There was a problem hiding this comment.
Might be good to verify that the survey successfully updates in the database here.
There was a problem hiding this comment.
From what I can tell, these system tests aren't running at test time because neither Capybara or Selenium are required gems. Running the tests manually it tries to GET /surveys which doesn't exist. I think Sean was planning on having a section to edit/create survey submissions and these system tests were for that area. Not sure how he created the tests without the pages existing though.
Using another method here wouldn't make sense, becuase it would still have to check if @flag_found was valid being just as complex.
… of https://github.com/sesheikholeslam/ctf-scoreboard into rate-challenges-after-submission-mitre-cyber-academy#224
|
In progress PR that suggests an modified approach: sesheikholeslam#1 |
|
Now also closes #530 |
|
This pull request has conflict. Could you fix it @sesheikholeslam? |
1 similar comment
|
This pull request has conflict. Could you fix it @sesheikholeslam? |
Closes #224, #530: Allows users to complete a survey regarding a challenge once the user submits a correct flag to the challenge.