-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scripts to run under uv correctly #174
Conversation
981cdae
to
9ade959
Compare
9ade959
to
2466eb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks fine to me.
I had issues running commands via uv locally - it turned out I needed to be in the src/
folder to run them. Once i did that, everything worked OK to the extent that I could test it. This was on both macOS and Ubuntu. Can the docs note this? (FWIW, the Docker env worked as expected, and worked running the scripts from within the src/
folder too.)
You shouldn't need to be in |
Looks like I need to fix up historical changelogs, not sure why those never got consumed and why previous PRs never failed them. |
If I'm not in
From |
9abdffc
to
d986150
Compare
What are the relevant tickets?
N/A
Description (What does it do?)
The scripts weren't working for me with the usages in the readme and I initially missed the gotcha at the top. I initially implemented things this way when the tooling we used made this easier. Under
uv
isn't not exactly clear if/how we can get the ergonomics to work well so I just moved everything into ascripts/
folder for simpler usage.How can this be tested?
Run some commands to be sure they still work:
uv run scripts/changelog.py list -a common
uv run scripts/version.py show --app common
uv run scripts/release.py create --help
- can't actually run a release so this just verifies the command loads correctly