Skip to content

Commit

Permalink
Adding the changelogs back, updated the changelog check command to be…
Browse files Browse the repository at this point in the history
… OK with changelogs if the only the reqs change
  • Loading branch information
jkachel committed Dec 18, 2023
1 parent ae81d29 commit 083a1f5
Show file tree
Hide file tree
Showing 13 changed files with 519 additions and 0 deletions.
15 changes: 15 additions & 0 deletions build-support/bin/mitol/build_support/commands/changelog.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,21 @@ def _is_excluded(path):
)
has_changelogd_changes = len(changelogd_changes) > 0

# If there's changes to the base requirements.txt, then we need to allow for
# changelogs to exist without the app code changing. There won't necessarily be
# changes in the individual apps if we're just updating project-wide dependencies.
# So, if there's no source changes, check if there's been changes to the
# requirements, and treat that as source changes.

if not has_source_changes:
reqs_paths = [
"requirements/requirements-testing.txt",
"requirements/requirements.txt",
]

reqs_changes = base_commit.diff(target_commit, paths=reqs_paths)
has_source_changes = len(reqs_changes) > 0

if has_source_changes and not has_changelogd_changes:
echo(f"Changelog(s) are missing in {app_rel_path} for these changes:")
for change in source_changes:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->

### Changed

- Updated requirements and lockfiles to support Django 4.
- Removed support for Django 2.2.

<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->
<!--
### Security
- A bullet item for the Security category.
-->
Loading

0 comments on commit 083a1f5

Please sign in to comment.