Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: Update apt dependencies and GH workflows to suppor Python3.12 #1106

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

blarghmatey
Copy link
Member

What are the relevant tickets?

Fixes https://cicd.odl.mit.edu/teams/infrastructure/pipelines/docker-packer-pulumi-ovs/jobs/build-ovs-image-from-master/builds/17

Description (What does it do?)

Adds the missing pieces for ensuring that Python 3.12 builds properly and passes tests.

How can this be tested?

Ensure that all GH checks are passing and the Docker image builds without errors.

Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing due to astroid/pylint errors

Dockerfile Show resolved Hide resolved
Copy link

gitguardian bot commented May 16, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9430286 Triggered Generic Password 8b9b0bf .github/workflows/ci.yml View secret
9430286 Triggered Generic Password b6bb581 docker-compose.yml View secret
9430286 Triggered Generic Password b6bb581 docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants