-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the ocw search page to use the new search apis #1294
Update the ocw search page to use the new search apis #1294
Comments
One issue with this plan is that the reddit part of open-discussions has a search feature which uses course-search-utils and will be pinned to an old release of course-search-utils. I think this is ok. We don't have plans for further development for discussions and if we ever need to make changes to the query generating code (because of a breaking change in open search, say) we can fork course-search-utils. |
Alternatively we can fork course-search-utils now, but I'm hoping we won't need to do more development on the channel/discussion search so we can hold off |
If we release the new version as 3.x, we should be fine. Renovate in open-discussions repository shouldn't bump a major version. And if we ever needed to fix something critical in the old 2.x branch, we could. I'm going to take a closer look at |
We changed the search apis on open to accept filter parameters instead of an open search query. This will be the api we will be using going forward. For now OCW is using the legacy search api that is separately running on open-discussions. We want to update ocw to use the new apis so we no longer need to support the legacy search.
The bulk of the updates will happen in course-search-utils. Currently course-search-utils
Now that we are moving to a new api we can get rid of (3) but (1) and (2) is still code that we want to share among all uis that use the search.
The work that needs to be done is
In course-search-utils:
type
is nowresource_type
and the facet formerly called 'resource_typeis
content_feature_type`In ocw-hugo-themes:
To make sure that everything works together the course-search-utils and ocw-hugo-themes work should happen silmultaneously
The text was updated successfully, but these errors were encountered: