Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new api changes #64

Merged
merged 1 commit into from
Feb 14, 2024
Merged

use new api changes #64

merged 1 commit into from
Feb 14, 2024

Conversation

abeglova
Copy link
Contributor

@abeglova abeglova commented Feb 6, 2024

What are the relevant tickets?

closes mitodl/ocw-hugo-themes#1294

Description (What does it do?)

This pr updates the search to use the new open apis.

These are the course-search-utils changes necessary for mitodl/ocw-hugo-themes#1313

How can this be tested?

Follow the instructions in mitodl/ocw-hugo-themes#1313
This pr needs to be merged before the ocw-hugo-themes pr

Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense and are working well in the OCW PR.

I would still like to make the changes in https://gist.github.com/ChristopherChudzicki/fbae5f3d57b3a1b70c77d69705578e14, but I don't see any reason we can't just release this as a 3.x major version, then release those changes as a 4.x major version.

This should be a major version bump, though. 👍

Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abeglova abeglova merged commit 903af29 into main Feb 14, 2024
2 checks passed
@odlbot odlbot mentioned this pull request Feb 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the ocw search page to use the new search apis
2 participants