-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop six and refactor #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
385e479
to
8c5aabf
Compare
BryanttV
reviewed
Nov 20, 2024
BryanttV
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
blarghmatey
approved these changes
Nov 25, 2024
Sorry I dropped the ball here... my job got really busy! This looks WONDERFUL though. So happy to see all the junk that we had to include to support python 2 + 3 at the same time go!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fully removes the
six
package and refactors some code.Related to #326
Note
I think it is easier to review this PR by commit.
Details
coerce_string_keys_to_text_type
function because the keys in dictionaries are no longer unicode strings.abstractproperty
. More aboutabstractproperty
: https://docs.python.org/3/library/abc.html#abc.abstractproperty__future__
imports because our imports were for supporting Python < 3. Ref: https://docs.python.org/3/library/__future__.html#module-contentsHow to test
Code
All the checks are passed.
Integration
Environment
Data
For more info:
tutor dev do importdemocourse -h
Test
python_lib.zip
and add this one:python_lib.zip
Note
If you want to create your python_lib from this version, you can clone the repo, enter in it, and then:
Screencasts
Everything still works as expected.
Screencast.from.2024-11-15.17-20-41.webm