Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop six and refactor #329

Merged
merged 13 commits into from
Nov 25, 2024
Merged

chore: drop six and refactor #329

merged 13 commits into from
Nov 25, 2024

Conversation

MaferMazu
Copy link
Collaborator

@MaferMazu MaferMazu commented Nov 15, 2024

Description

This PR fully removes the six package and refactors some code.

Related to #326

Note

I think it is easier to review this PR by commit.

Details

How to test

Code

All the checks are passed.

Integration

Environment

  • Have a tutor environment with Tutor v18.1.4
  • Install codejail. You can follow the installation and usage process from the tutor-contrib-codejail README.
  • Perform a dev launch

Data

  • Import the MIT demo course running:
tutor dev do importdemocourse -r https://github.com/mitodl/mitx-grading-library -d course -v master

For more info: tutor dev do importdemocourse -h

  • Create an admin user
tutor dev do createuser --staff --superuser admin [email protected]

Test

  1. Enter in Studio > MITx Grading Library > Content > Files
  2. Remove the python_lib.zip and add this one:
    python_lib.zip

Note

If you want to create your python_lib from this version, you can clone the repo, enter in it, and then:

find mitxgraders voluptuous -type f ! -path "*/__pycache__/*" | zip python_lib.zip -@
  1. Make sure the units are rendered and worked well.

Screencasts

Everything still works as expected.

Screencast.from.2024-11-15.17-20-41.webm

@MaferMazu MaferMazu marked this pull request as ready for review November 15, 2024 21:09
@MaferMazu MaferMazu requested a review from BryanttV November 25, 2024 14:28
Copy link

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaferMazu MaferMazu merged commit b0b1195 into mitodl:master Nov 25, 2024
4 checks passed
@jolyonb
Copy link
Collaborator

jolyonb commented Nov 26, 2024

Sorry I dropped the ball here... my job got really busy! This looks WONDERFUL though. So happy to see all the junk that we had to include to support python 2 + 3 at the same time go!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants