Update MITx Online ETL to not parse the readable ID for departments #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les, test new department parser This fails tests because the generate_course_numbers_json also extracts the departments out; need to figure that out
for more information, see https://pre-commit.ci
|
Will this also close https://github.com/mitodl/hq/issues/4963 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not done yet - draft PR per request for work in progress.
What are the relevant tickets?
Closes mitodl/hq#4164
Description (What does it do?)
MITx Online's API for courses and programs specifies the departments these objects belong to, so the ETL tasks for these should use that rather than trying to parse the department out of the course readable ID.
How can this be tested?
Automated tests should pass.