Update version of react used in tests to same as production #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
added
the
Needs Review
| @@ -124,7 +124,7 @@ const expectLastProps = ( | |||
| ) => { | |||
| expect(fc).toHaveBeenLastCalledWith( | |||
| expect.objectContaining(partialProps), | |||
| expect.anything(), | |||
| expect.toBeOneOf([expect.anything(), undefined]), | |||
There was a problem hiding this comment.
Evidently how react calls functional components changed a little between react 18 -> 19.
It used to call them as func(props, something_i_didnt_understand), now it calls them as func(props, undefined). This is irrelevant and is is already what's happening in MIT Learn on RC/Prod.
This was referenced Dec 20, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None
Related to #1916, which is failing artificially due to incorrect version of react.
Description (What does it do?)
This PR updates the version of React to ^19.
This is the version of react used in our JSDOM tests, not production. NextJS bundles react internally, and we're on NextJS 15. It already uses react 19. 1
How can this be tested?
CI should pass. (This change does not affect production.)
Footnotes
Our version of NextJS actually uses a canary react 19, namely
19.0.0-rc-02c0e824-20241028, which you can see if you add aconsole.log(React)into the application somewhere. Projects like NextJS using canary react is expected by the react developers. See https://react.dev/blog/2023/05/03/react-canaries. We should update to a newer version of NextJS 15, which will use a non-canary react, but let's do that separately. ↩