Preserve two-output operations from Rewriter Pipeline to Bedrock2 #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 1, 2023 14:04
… with internal casts were failing
…out things that rely on mul_split
* `Stringification.v`: it provides (somewhat arbitrarily chosen) names for the `add_carryx` and `sub_borrowx` functions when building a value of type `Type.parameters`. * `UnsaturatedSolinas.v`: it pushses through broken proofs that did not have cases for `add_carryx` and `sub_borrowx`, temporarily admitting the subcases. The current known obstacle to building is in `Field1305.v`, which cannot derive `fe1305_to_bytes`. This isn't unexplainable, given that the attempted proof for derivation is `derive_bedrock2_func to_bytes_op` and `to_bytes_op` is modified by the current changes. However, it's a bit surprising given that deriving `fe1305_from_bytes` succeeds with the proof `derive_bedrock2_func from_bytes_op`, and `to_bytes_op` doesn't seem to actually depend on the `add_carryx` and `sub_borrowx` parameters added to its environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.