-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving at level 10 notations which were originally at level 200 #1695
Moving at level 10 notations which were originally at level 200 #1695
Conversation
Does the docker image need to be updated? I see
on master. Maybe the segfault on Field is from par? Is it an OOM? I don't think ulimit should be essential |
e7d2920
to
e0cc85c
Compare
Sorry, I'm a bit ignorant about CI and I don't know what you are referring to by "docker image". In any case, I pushed a fix so that, hopefully, the test against master works. |
I mean https://github.com/coq-community/docker-coq / https://hub.docker.com/r/coqorg/coq/. I'm going to rebase the branch to make sure that failure on 8.16 / 8.17 doesn't make master fail. |
e0cc85c
to
6611f23
Compare
CI says
|
Is it the right version of Coq (it seems to say |
Oh, urgh, I need to update this to use docker instead of my ppa. My ppa version is blocked on coq/coq#18105 (comment) |
This follows what was done for notations at level binder_constr in Coq PR #18014.
6611f23
to
991c3c9
Compare
Rebased to use actual master now. But it seems that we might be failing with
|
This does not build, but I will merge it anyway so Coq's CI won't be blocked on this. It seems a new regression was introduced into Coq in the mean time. |
This follows what was done for notations at level binder_constr in Coq PR #18014.
This should fix the compilation of fiat crypto legacy in Coq CI, but I could not fully check (I get a segfault on src/Algebra/Field.v, maybe due to a previous failure to set the ulimit??)