-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow bedrock2 pipeline to call external functions. #1640
Open
jadephilipoom
wants to merge
34
commits into
mit-plv:master
Choose a base branch
from
jadephilipoom:ext-func2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with internal casts were failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the bedrock2 backend for fiat-crypto to interpret add-carry and sub-borrow instructions by calling external bedrock2 functions. I changed the arguments to the fiat-crypto pipeline so that it produces expressions containing
mul_split
,add_get_carry
,add_with_get_carry
,sub_get_borrow
, andsub_with_get_borrow
, then implemented support for the add/sub instructions.The next step is to add support for
mul_split
; I'd like to hand that task off to someone else at this point, but I prepared some debugging printouts inp224_64_new.v
that are similar to the printouts I used while developing the add/sub code.Other, secondary changes in this PR include:
spec_of
preconditions added new hypotheses, which made the autogenerated names break; I tried to remove all the auto-generated names I came acrossExpr
layer of the bedrock2 translation handles caststranslate_expr
now has to handle other cast sizes; it does this by introducingand
operations whenever the cast doesn't match the word size. This might result in a few superfluous ands, but hopefully C compilers will be able to optimize them away.Most of those secondary changes are one-time, so
mul_split
should be less complicated. The commit that adds subtraction (message: "works with sub, but fails to handle carries which are literals") should give a good sense of what needs to change to add a new special-case function