Implement Trendline for iOS #3272
Conversation
Change-Id: I335fea5906375f6e65993b69c2d729bbd4aadc8c
Change-Id: Ia2324a0800ced921c2622d1329485f1541331eab
| // | ||
| // ChartComponent.swift | ||
| // AIComponentKit | ||
| // | ||
| // Created by David Kim on 3/19/24. | ||
| // Copyright © 2024 Massachusetts Institute of Technology. All rights reserved. | ||
| // |
There was a problem hiding this comment.
Correct the header to match the other files, including the license.
| // Method to initialize the chart data object | ||
| func initChartData() |
| // | ||
| // DataCollection.swift | ||
| // AIComponentKit | ||
| // | ||
| // Created by David Kim on 3/28/24. | ||
| // Copyright © 2024 Massachusetts Institute of Technology. All rights reserved. | ||
| // |
| // | ||
| // DataModel.swift | ||
| // AIComponentKit | ||
| // | ||
| // Created by David Kim on 3/28/24. | ||
| // Copyright © 2024 Massachusetts Institute of Technology. All rights reserved. | ||
| // |
| private var _dataFileColumns: [String]? | ||
| var dataFileColumns: [String]? { | ||
| get { _dataFileColumns } | ||
| set { _dataFileColumns = newValue } | ||
| } | ||
|
|
||
| private var _useSheetHeaders: Bool = false | ||
| var useSheetHeaders: Bool { | ||
| get { _useSheetHeaders } | ||
| set { _useSheetHeaders = newValue } | ||
| } | ||
|
|
||
| private var _sheetsColumns: [String]? | ||
| var sheetsColumns: [String]? { | ||
| get { _sheetsColumns } | ||
| set { _sheetsColumns = newValue } | ||
| } | ||
|
|
||
| private var _webColumns: [String]? | ||
| var webColumns: [String]? { | ||
| get { _webColumns } | ||
| set { _webColumns = newValue } | ||
| } | ||
|
|
||
| private var _dataSourceKey: String? | ||
| var dataSourceKey: String? { | ||
| get { _dataSourceKey } | ||
| set { _dataSourceKey = newValue } | ||
| } | ||
|
|
||
| private var __elements: String? | ||
| var _elements: String? { | ||
| get { __elements } | ||
| set { __elements = newValue } | ||
| } | ||
|
|
||
| private var __initialized: Bool = false | ||
| var _initialized: Bool { | ||
| get { __initialized } | ||
| set { __initialized = newValue } | ||
| } | ||
|
|
||
| private var __tick: Int = 0 | ||
| var _tick: Int { | ||
| get { __tick } | ||
| set { __tick = newValue } | ||
| } |
There was a problem hiding this comment.
Note that if these don't need to have any special get/set logic they could simplified to just var foo: type = default
| @@ -0,0 +1,86 @@ | |||
| // | |||
| // print(points[0].x) | ||
| // if (points[0].x == 1.7976931348623157e+308){ | ||
| // return | ||
| // } |
There was a problem hiding this comment.
If this code isn't needed please remove it.
| //TODO: how can we resolve this? | ||
| // @objc public class func fromUnderlyingValue(_ value: String) -> StrokeStyle? { | ||
| // if let intValue = Int(value) { | ||
| // return fromUnderlyingValue(intValue) | ||
| // } | ||
| // return nil | ||
| // } |
There was a problem hiding this comment.
I think for this we will need to have the function take AnyObject and then handle the Int vs String issue internally since Objective-C doesn't have method overloading.
There was a problem hiding this comment.
It seems like many of the properties of the Trendline component do not have the correct capitalization. It's not clear that they would be found by the glue code in SchemeKit that connects the block code to the Swift code. Can you double check that the various getter properties are all working correctly?
|
|
||
| @objc public var ChartData: ChartData2D { | ||
| get { | ||
| return _chartData! |
There was a problem hiding this comment.
Be careful with the forced unwrapping here since if for some reason _chartData is nil when this is called it will crash the app.
-What does this PR accomplish?
Adds the trendline component for ios