Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): localOnlyなノートの時は配送処理そのものを起動しない #15020

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

※2024.11.0の次にしたい

What

連合OFFなノートを作成した直後の連合処理を抑止する条件を追加しました

Why

fix #15018

Additional info (optional)

修正を入れたバージョンで、連合OFFなノートが連合されないこと、連合ONのノートが連合されることを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.96%. Comparing base (dd56623) to head (26e0b77).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/NoteCreateService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15020   +/-   ##
========================================
  Coverage    39.96%   39.96%           
========================================
  Files         1563     1563           
  Lines       197744   197744           
  Branches      3631     3634    +3     
========================================
+ Hits         79024    79033    +9     
- Misses      118115   118138   +23     
+ Partials       605      573   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito samunohito marked this pull request as ready for review November 21, 2024 12:56
@kakkokari-gtyih kakkokari-gtyih added this to the v2024.11.1? milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
2 participants