Replace VMD by Pilot 1 of X: Pilot Components #60
+339
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🦀 Requesting reviewers for this pull request:
🦀 Mentionning users for this pull request:
|
OlivierPineau
approved these changes
Jan 14, 2025
| Text(viewModel.projectType.first) | ||
| .textStyle(.subHeadline, .semiBold, textColor) | ||
| .fixedSize(horizontal: false, vertical: true) | ||
| if let headline = viewModel.projectType.first as? String { |
There was a problem hiding this comment.
Why did you need to cast to String for both of the labels here?
There was a problem hiding this comment.
You are right, we didn't need to cast it. Wrapping it like this: String(headline), was enough to pass a NSString in a SwiftUI Text.
ma-meza
added a commit
that referenced
this pull request
Mar 12, 2025
…63) * Replace VMD by Pilot 1 of X: Pilot Components (#60) * Replace VMD by Pilot 2 of X: Common viewmodels and Android navigation (#61) * Replace VMD by Pilot 3 of 3: iOS navigation and views (#62) * Remove all references to Trikot VMD (Android & Common) 🎉 * Remove all references to Trikot VMD (iOS) 🎉 * Final cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Replace VMD components by the ones from the new Pilot library: https://github.com/mirego/viewmodel-pilot/blob/main/docs/components.md
🦀 Dispatch
#dispatch/kmp