-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace VMD by Pilot 1 of X: Pilot Components #60
Conversation
🦀 Requesting reviewers for this pull request:
🦀 Mentionning users for this pull request:
|
Text(viewModel.projectType.first) | ||
.textStyle(.subHeadline, .semiBold, textColor) | ||
.fixedSize(horizontal: false, vertical: true) | ||
if let headline = viewModel.projectType.first as? String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to cast to String for both of the labels here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, we didn't need to cast it. Wrapping it like this: String(headline)
, was enough to pass a NSString in a SwiftUI Text.
…63) * Replace VMD by Pilot 1 of X: Pilot Components (#60) * Replace VMD by Pilot 2 of X: Common viewmodels and Android navigation (#61) * Replace VMD by Pilot 3 of 3: iOS navigation and views (#62) * Remove all references to Trikot VMD (Android & Common) 🎉 * Remove all references to Trikot VMD (iOS) 🎉 * Final cleanup
📖 Description
Replace VMD components by the ones from the new Pilot library: https://github.com/mirego/viewmodel-pilot/blob/main/docs/components.md
🦀 Dispatch
#dispatch/kmp