PR review

mirego · Dec 19, 2023 · 5f33ace · 5f33ace
1 parent 5cad54c
commit 5f33ace
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/cli/src/commands/stats.ts b/cli/src/commands/stats.ts
@@ -29,8 +29,8 @@ export default class Stats extends Command {
   async run() {
     const {flags} = this.parse(Stats);
 
-    if (this.projectConfig.config.version?.identifier && !flags.version) {
-      flags.version = this.projectConfig.config.version.identifier;
+    if (this.projectConfig.config.version?.tag && !flags.version) {
+      flags.version = this.projectConfig.config.version.tag;
     }
 
     if (flags.version) {

diff --git a/cli/src/commands/sync.ts b/cli/src/commands/sync.ts
@@ -74,7 +74,7 @@ export default class Sync extends Command {
     const t0 = process.hrtime.bigint();
     const documents = this.projectConfig.files();
 
-    if (this.projectConfig.config.version?.identifier && !flags.version) {
+    if (this.projectConfig.config.version?.tag && !flags.version) {
       flags.version = this.config.version;
     }
 

diff --git a/cli/src/services/config.ts b/cli/src/services/config.ts
@@ -38,14 +38,12 @@ export default class ConfigFetcher {
       error('You must have at least 1 document set in your config');
     }
 
-    const branchName = this.getCurrentBranchName();
-
     if (
       this.config.version?.branchVersionPrefix &&
-      branchName.startsWith(this.config.version?.branchVersionPrefix)
+      this.getCurrentBranchName().startsWith(this.config.version?.branchVersionPrefix)
     ) {
-      this.config.version.identifier = this.exctractVersionFromBranch(
-        branchName,
+      this.config.version.tag = this.exctractVersionFromBranch(
+        this.getCurrentBranchName(),
         this.config.version?.branchVersionPrefix
       );
     }

diff --git a/cli/src/types/version-config.ts b/cli/src/types/version-config.ts
@@ -1,4 +1,4 @@
 export interface VersionConfig {
   branchVersionPrefix?: string;
-  identifier?: string;
+  tag?: string;
 }