Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-4073 Enable SSO in production #1994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zheileman
Copy link
Member

Description

Follow-up to PRs #1946 and #1977.

Kubernetes ENV variables added for production environment, and feature flag turned ON.

SSO has been already turned on in all non-production envs.

To be merged and released once we have the green light.

Self-review checklist

  • (1) Quick stakeholder demo done OR
  • (2) ...bug with before and after screenshots
  • (3) Tests passing
  • (4) Branch ready to be merged (not work in progress)
  • (5) No superfluous changes in diff
  • (6) No TODO's without new ticket numbers
  • (7) PR Prefixed with ticket number e.g. CT-7654 ...
  • (8) Data migration script is created if any of letter templates is changed

Screenshots

Related JIRA tickets

Deployment

Do not release to production until we have the green light.

Manual testing instructions

Once merged and released to production, a button to sign in with SSO will show in the login page.

Follow-up to PRs #1946 and #1977.

Kubernetes ENV variables added for production environment, and feature flag turned ON.

SSO has been already turned on in all non-production envs.

To be merged and released once we have the green light.
@zheileman zheileman requested a review from a team as a code owner May 20, 2022 10:23
Copy link

@willmcb willmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants