Make endpoint config optional in AWS secrets-manager keystore config #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with IRSA on EKS with a config like this: keystore:
aws:
secretsmanager:
region: us-east-1
kmskey: arn:aws:kms:us-east-1:... |
derSascha
force-pushed
the
aws-secrets-manager-make-endpoint-optional
branch
from
7ca80b5 to
3be2fd3
Compare
The AWS SDK contains a set of pre-configured endpoints. Make the endpoint config optional, and let the SDK decide what endpoint should be used.
derSascha
force-pushed
the
aws-secrets-manager-make-endpoint-optional
branch
from
3be2fd3 to
b44a799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS SDK contains a set of pre-configured endpoints. Make the endpoint config optional, and let the SDK decide what endpoint should be used. This fixes #495. See #495 about more details.
Maybe we should make the region optional too. Both can be autoconfigured by the SDK.