Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for two issues #1392

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Bug fixes for two issues #1392

merged 3 commits into from
Jan 13, 2025

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Jan 13, 2025

Tenant Namespaces

Adds information for unique tenant namespaces.

Closes #1391

Staged:

Changing erasure code parity

Adds information about changes to erasure code to MNMD deploys.

Closes #1365

Staged:

Closes #1391

Adds information about changes to erasure code to MNMD deploys.

Closes #1365
@djwfyi djwfyi self-assigned this Jan 13, 2025
Comment on lines 206 to 207
The tenant must use its own namespace with no other tenant.
MinIO strongly recommends using a dedicated namespace for the tenant with no other applications running in the namespace.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps

Suggested change
The tenant must use its own namespace with no other tenant.
MinIO strongly recommends using a dedicated namespace for the tenant with no other applications running in the namespace.
The tenant must use its own namespace and cannot share a namespace with another tenant.
In addition, MinIO strongly recommends using a dedicated namespace for the tenant with no other applications running in the namespace.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for the other occurrence of this text

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied!

Copy link
Collaborator

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also an idea you might like

@cniackz cniackz self-requested a review January 13, 2025 16:20
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @djwfyi

@djwfyi djwfyi merged commit 9e7388c into main Jan 13, 2025
1 check passed
@djwfyi djwfyi deleted the bug-fixes branch January 13, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants